Install Nginx 1.4.1 from the official repository

Nginx 1.4.1 is not available in the Ubuntu repository yet, so this switches to the official repository.

I had to remove the apt update from the pre stage and add a dependency chain with Package instead, which is the cleaner solution anyway. With apt update running in the pre stage, we couldn't add additional sources using the apt package.

Also changed the server configuration of Discourse to make sure we listen on port 80 for ipv4.

[Wladimir Palant, 2013-05-18 09:52:32]

LGTM but I have a question below.

http://codereview.adblockplus.org/10590026/diff/1/modules/nginx/manifests/ini...
File modules/nginx/manifests/init.pp (right):

http://codereview.adblockplus.org/10590026/diff/1/modules/nginx/manifests/ini...
modules/nginx/manifests/init.pp:17: ensure => '1.4.1-1~precise',
Will that also allow for newer versions?

[Felix Dahlke, 2013-05-21 05:40:57]

http://codereview.adblockplus.org/10590026/diff/1/modules/nginx/manifests/ini...
File modules/nginx/manifests/init.pp (right):

http://codereview.adblockplus.org/10590026/diff/1/modules/nginx/manifests/ini...
modules/nginx/manifests/init.pp:17: ensure => '1.4.1-1~precise',
On 2013/05/18 09:52:32, Wladimir Palant wrote:
> Will that also allow for newer versions?

No, this will install exactly this version. I've thought a bit about how we can
handle security upgrades, and I see three options:

1) Use "ensure => present" and use something like apt-cron to automatically
install security updates
2) Use "ensure => latest" to make Puppet automatically install the newest
available version
3) Use "ensure => $version" to install the exact version we want.

I thought option 1 was our way to go, but in the case of the latest Nginx
update, we would have broken it on all servers, that's something I'd love to
avoid.

Option 2 is similar to option 1, except that we'll at least install the update
during the puppet update, i.e. we're more likely to notice issues. In a way,
it's more dangerous than option 1 though, since these are all upgrades, not just
security upgrades.

Option 3 seems like the best bet. When a new version of Nginx is released, we
have control over when we upgrade, and should thus be able to avoid issues.