Make all our applications work with Nginx 1.4.1

There were still a couple of issues with Nginx 1.4.1, but now everything works.

I have updated the following servers with this:

server_1, server_3, server_4, server_10, server_11, server_12.

I'll roll it out on the remaining filter servers later today.

[Felix Dahlke, 2013-05-22 04:50:28]

http://codereview.adblockplus.org/10630004/diff/1/modules/nagios/templates/si...
File modules/nagios/templates/site.erb (right):

http://codereview.adblockplus.org/10630004/diff/1/modules/nagios/templates/si...
modules/nagios/templates/site.erb:61: fastcgi_param SCRIPT_FILENAME
$document_root/$fastcgi_script_name;
This took quite a while to figure out, any idea what the underlying problem is
and how we can solve it better?

http://codereview.adblockplus.org/10630004/diff/1/modules/nginx/templates/ngi...
File modules/nginx/templates/nginx.conf.erb (right):

http://codereview.adblockplus.org/10630004/diff/1/modules/nginx/templates/ngi...
modules/nginx/templates/nginx.conf.erb:48: server_names_hash_bucket_size 64;
This was necessary for intraforum.adblockplus.org. I'm surprised it wasn't
there, as I remember changing that in the past.

[Wladimir Palant, 2013-05-22 06:22:31]

LGTM but I would like to see the comments addressed.

http://codereview.adblockplus.org/10630004/diff/1/modules/nagios/templates/si...
File modules/nagios/templates/site.erb (right):

http://codereview.adblockplus.org/10630004/diff/1/modules/nagios/templates/si...
modules/nagios/templates/site.erb:61: fastcgi_param SCRIPT_FILENAME
$document_root/$fastcgi_script_name;
On 2013/05/22 04:50:28, Felix H. Dahlke wrote:
> This took quite a while to figure out, any idea what the underlying problem is
> and how we can solve it better?

This is actually the proper solution, FastCGI doesn't assume that the scripts
are really located under the HTTP root - and in case of our Anwiki install for
example they aren't. You don't need the slash however, it's
$document_root$fastcgi_script_name. Please change the location block above
similarly - set SCRIPT_FILENAME via $document_root there as well.

http://codereview.adblockplus.org/10630004/diff/1/modules/nginx/manifests/ini...
File modules/nginx/manifests/init.pp (right):

http://codereview.adblockplus.org/10630004/diff/1/modules/nginx/manifests/ini...
modules/nginx/manifests/init.pp:19: before => Package['nginx']
Will this uninstall nginx-full as well?

[Felix Dahlke, 2013-05-22 06:59:49]

Issue addressed, closing this.

http://codereview.adblockplus.org/10630004/diff/1/modules/nagios/templates/si...
File modules/nagios/templates/site.erb (right):

http://codereview.adblockplus.org/10630004/diff/1/modules/nagios/templates/si...
modules/nagios/templates/site.erb:61: fastcgi_param SCRIPT_FILENAME
$document_root/$fastcgi_script_name;
On 2013/05/22 06:22:31, Wladimir Palant wrote:
> On 2013/05/22 04:50:28, Felix H. Dahlke wrote:
> > This took quite a while to figure out, any idea what the underlying problem
is
> > and how we can solve it better?
> 
> This is actually the proper solution, FastCGI doesn't assume that the scripts
> are really located under the HTTP root - and in case of our Anwiki install for
> example they aren't. You don't need the slash however, it's
> $document_root$fastcgi_script_name. Please change the location block above
> similarly - set SCRIPT_FILENAME via $document_root there as well.

Done. Don't really get why this wasn't necessary with Nginx 1.1.9 though.
Thought there may have been some global setting making script files default to
$documentroot.

http://codereview.adblockplus.org/10630004/diff/1/modules/nginx/manifests/ini...
File modules/nginx/manifests/init.pp (right):

http://codereview.adblockplus.org/10630004/diff/1/modules/nginx/manifests/ini...
modules/nginx/manifests/init.pp:19: before => Package['nginx']
On 2013/05/22 06:22:31, Wladimir Palant wrote:
> Will this uninstall nginx-full as well?

Yes. I tried to purge nginx-full originally, but that resulted in dependency
issues.