Avoid duplication between AdblockPlus and AdblockPlusEngine

I had to use precompiled headers in AdblockPlusEngine and make each project define the name of its precompiled header for the shared files to work in both projects.

It'd be nicer to move away from precompiled headers in both projects in the long term I think.

[Wladimir Palant, 2013-05-27 09:51:55]

LGTM though we might want to make Communication a bit more self-contained in the
long term.

http://codereview.adblockplus.org/10774005/diff/3001/src/engine/main.cpp
File src/engine/main.cpp (right):

http://codereview.adblockplus.org/10774005/diff/3001/src/engine/main.cpp#newc...
src/engine/main.cpp:4: #include "../shared/Communication.h"
I wonder whether we should add an include directory to the project rather than
using relative paths here. Oleksandr, what do you think?

http://codereview.adblockplus.org/10774005/diff/3001/src/shared/AutoHandle.cpp
File src/shared/AutoHandle.cpp (right):

http://codereview.adblockplus.org/10774005/diff/3001/src/shared/AutoHandle.cp...
src/shared/AutoHandle.cpp:18: HANDLE AutoHandle::get()
I would rather do this as AutoHandle::operator HANDLE() - but it's a matter of
taste of course.

[Oleksandr, 2013-05-27 15:32:09]

Precompiled headers seem messed up, but I'll tackle that. Other then that LGTM.

On 2013/05/27 09:51:55, Wladimir Palant wrote:
> LGTM though we might want to make Communication a bit more self-contained in
the
> long term.
> 
> http://codereview.adblockplus.org/10774005/diff/3001/src/engine/main.cpp
> File src/engine/main.cpp (right):
> 
>
http://codereview.adblockplus.org/10774005/diff/3001/src/engine/main.cpp#newc...
> src/engine/main.cpp:4: #include "../shared/Communication.h"
> I wonder whether we should add an include directory to the project rather than
> using relative paths here. Oleksandr, what do you think?
> 
> http://codereview.adblockplus.org/10774005/diff/3001/src/shared/AutoHandle.cpp
> File src/shared/AutoHandle.cpp (right):
> 
>
http://codereview.adblockplus.org/10774005/diff/3001/src/shared/AutoHandle.cp...
> src/shared/AutoHandle.cpp:18: HANDLE AutoHandle::get()
> I would rather do this as AutoHandle::operator HANDLE() - but it's a matter of
> taste of course.

[Oleksandr, 2013-05-27 15:32:26]

http://codereview.adblockplus.org/10774005/diff/3001/src/engine/main.cpp
File src/engine/main.cpp (right):

http://codereview.adblockplus.org/10774005/diff/3001/src/engine/main.cpp#newc...
src/engine/main.cpp:4: #include "../shared/Communication.h"
On 2013/05/27 09:51:55, Wladimir Palant wrote:
> I wonder whether we should add an include directory to the project rather than
> using relative paths here. Oleksandr, what do you think?
Include directories are generally used for third-party includes, I think. So in
my opinion we shouldn't use it here. Besides, relative paths here keep you alert
this is shared code.

http://codereview.adblockplus.org/10774005/diff/3001/src/shared/AutoHandle.cpp
File src/shared/AutoHandle.cpp (right):

http://codereview.adblockplus.org/10774005/diff/3001/src/shared/AutoHandle.cp...
src/shared/AutoHandle.cpp:2: 
It is usually just #include stdafx.h. No need to use the predefined value. Here
especially, since stdafx is not available from the "shared" directory. I'd move
stdafx.h to the Shared folder or add the Engine folder to Additional Include
Folders.

[Felix Dahlke, 2013-06-04 09:50:40]

http://codereview.adblockplus.org/10774005/diff/3001/src/shared/AutoHandle.cpp
File src/shared/AutoHandle.cpp (right):

http://codereview.adblockplus.org/10774005/diff/3001/src/shared/AutoHandle.cp...
src/shared/AutoHandle.cpp:18: HANDLE AutoHandle::get()
On 2013/05/27 09:51:55, Wladimir Palant wrote:
> I would rather do this as AutoHandle::operator HANDLE() - but it's a matter of
> taste of course.

That's actually nicer, will do.