Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10825021: Move settings page into the application directory (Closed)

Created:
June 3, 2013, 11:40 a.m. by Wladimir Palant
Modified:
June 19, 2013, 5:37 p.m.
Reviewers:
Felix Dahlke, Oleksandr
Visibility:
Public.

Description

Move settings page into the application directory

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed nit and removed copying of html directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3125 lines, -3129 lines) Patch
M src/plugin/AdblockPlusClient.cpp View 1 1 chunk +371 lines, -378 lines 0 comments Download
M src/plugin/PluginClass.cpp View 1 1 chunk +2222 lines, -2222 lines 0 comments Download
M src/plugin/PluginSettings.cpp View 1 1 chunk +0 lines, -33 lines 0 comments Download
M src/plugin/PluginTabBase.cpp View 1 1 chunk +449 lines, -449 lines 0 comments Download
M src/plugin/PluginUtil.h View 1 1 chunk +18 lines, -6 lines 0 comments Download
M src/plugin/PluginUtil.cpp View 1 1 chunk +65 lines, -41 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
June 3, 2013, 11:41 a.m. (2013-06-03 11:41:00 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/10825021/diff/1/src/plugin/AdblockPlusClient.cpp File src/plugin/AdblockPlusClient.cpp (left): http://codereview.adblockplus.org/10825021/diff/1/src/plugin/AdblockPlusClient.cpp#oldcode77 src/plugin/AdblockPlusClient.cpp:77: DEBUG_GENERAL(e.what()); I had to remove the try..catch block here ...
June 3, 2013, 11:43 a.m. (2013-06-03 11:43:31 UTC) #2
Felix Dahlke
http://codereview.adblockplus.org/10825021/diff/1/src/plugin/PluginUtil.h File src/plugin/PluginUtil.h (right): http://codereview.adblockplus.org/10825021/diff/1/src/plugin/PluginUtil.h#newcode8 src/plugin/PluginUtil.h:8: ~BString(); Needs a custom copy constructor and copy assignment ...
June 4, 2013, 7:08 a.m. (2013-06-04 07:08:39 UTC) #3
Wladimir Palant
I also removed the code responsible for copying html directory to AppData/LocalLow - forgot about ...
June 4, 2013, 9:17 a.m. (2013-06-04 09:17:29 UTC) #4
Felix Dahlke
June 4, 2013, 9:27 a.m. (2013-06-04 09:27:23 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld