Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10836037: Share code for data path retrieval in engine and plugin (Closed)

Created:
June 4, 2013, 9:54 a.m. by Wladimir Palant
Modified:
June 19, 2013, 5:37 p.m.
Reviewers:
Felix Dahlke, Oleksandr
Visibility:
Public.

Description

Note that this changes the data path as discussed earlier.

Patch Set 1 #

Patch Set 2 : Fixed issues in previous patch #

Total comments: 2

Patch Set 3 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -122 lines) Patch
M AdblockPlusEngine.vcxproj View 1 chunk +3 lines, -1 line 0 comments Download
M AdblockPlusPlugin.vcxproj View 1 chunk +3 lines, -0 lines 0 comments Download
M src/engine/Debug.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/engine/main.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/PluginSettings.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M src/plugin/PluginSettings.cpp View 1 2 4 chunks +3 lines, -110 lines 0 comments Download
M src/plugin/abp.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/shared/Utils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/shared/Utils.cpp View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
June 4, 2013, 9:54 a.m. (2013-06-04 09:54:49 UTC) #1
Felix Dahlke
LGTM
June 4, 2013, 10:13 a.m. (2013-06-04 10:13:35 UTC) #2
Felix Dahlke
Reviewed the latest patch http://codereview.adblockplus.org/10836037/diff/4001/src/plugin/PluginSettings.cpp File src/plugin/PluginSettings.cpp (right): http://codereview.adblockplus.org/10836037/diff/4001/src/plugin/PluginSettings.cpp#newcode314 src/plugin/PluginSettings.cpp:314: std::wstring path = ::GetAppDataPath() + ...
June 4, 2013, 10:18 a.m. (2013-06-04 10:18:09 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/10836037/diff/4001/src/plugin/PluginSettings.cpp File src/plugin/PluginSettings.cpp (right): http://codereview.adblockplus.org/10836037/diff/4001/src/plugin/PluginSettings.cpp#newcode314 src/plugin/PluginSettings.cpp:314: std::wstring path = ::GetAppDataPath() + L"\\" + (LPCWSTR)filename; It's ...
June 4, 2013, 10:39 a.m. (2013-06-04 10:39:03 UTC) #4
Felix Dahlke
June 4, 2013, 11:35 a.m. (2013-06-04 11:35:31 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld