Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10845030: Marshal all libadblockplus calls to the engine process (Closed)

Created:
May 31, 2013, 2:20 p.m. by Wladimir Palant
Modified:
June 19, 2013, 5:38 p.m.
Reviewers:
Felix Dahlke, Oleksandr
Visibility:
Public.

Description

Marshal all libadblockplus calls to the engine process

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -277 lines) Patch
M .hgsubstate View 1 chunk +1 line, -1 line 0 comments Download
M AdblockPlusPlugin.vcxproj View 16 chunks +8 lines, -24 lines 0 comments Download
M src/engine/main.cpp View 1 chunk +82 lines, -6 lines 2 comments Download
M src/plugin/AdblockPlusClient.h View 2 chunks +14 lines, -9 lines 0 comments Download
M src/plugin/AdblockPlusClient.cpp View 3 chunks +109 lines, -26 lines 0 comments Download
M src/plugin/PluginSettings.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/plugin/PluginSettings.cpp View 23 chunks +52 lines, -194 lines 0 comments Download
M src/plugin/PluginUserSettings.cpp View 7 chunks +13 lines, -13 lines 0 comments Download
M src/shared/Communication.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Wladimir Palant
May 31, 2013, 2:20 p.m. (2013-05-31 14:20:52 UTC) #1
Felix Dahlke
LGTM http://codereview.adblockplus.org/10845030/diff/1/src/engine/main.cpp File src/engine/main.cpp (right): http://codereview.adblockplus.org/10845030/diff/1/src/engine/main.cpp#newcode44 src/engine/main.cpp:44: const std::vector<std::string> strings) Shouldn't the strings be passed ...
June 4, 2013, 11:53 a.m. (2013-06-04 11:53:17 UTC) #2
Wladimir Palant
June 4, 2013, 12:07 p.m. (2013-06-04 12:07:16 UTC) #3

Powered by Google App Engine
This is Rietveld