Issue 10862008: Automatically add default filter subscription when necessary.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10862008: Automatically add default filter subscription when necessary. (Closed)

Created:
May 27, 2013, 2:12 p.m. by Wladimir Palant

Modified:
June 4, 2013, 2:24 p.m.

Reviewers:
Felix Dahlke, Oleksandr

Visibility:
Public.

Description

Several other changes along the way: * Pass in application locale to the JS engine * Allow passing arbitrary parameters in _triggerEvent() * Add FilterEngine::IsFirstRun() * Make Utils.checkLocalePrefixMatch() and Utils.chooseFilterSubscription() more like what they are in Firefox

Patch Set 1 #

Created: May 27, 2013, 2:12 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -38 lines)			Patch
M	include/AdblockPlus/AppInfo.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/AdblockPlus/FilterEngine.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	include/AdblockPlus/JsEngine.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/init.js	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	lib/utils.js	View	1 chunk	+11 lines, -13 lines	0 comments	Download
M	shell/src/Main.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/AppInfoJsObject.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/FilterEngine.cpp	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	src/GlobalJsObject.cpp	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/JsEngine.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/AppInfoJsObject.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/BaseJsTest.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	test/FilterEngine.cpp	View	3 chunks	+36 lines, -12 lines	0 comments	Download
M	test/JsEngine.cpp	View	2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages