Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 10977050: Define _DEBUG (Closed)

Created:
July 9, 2013, 2:44 p.m. by Felix Dahlke
Modified:
July 9, 2013, 3:15 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This was missing, we need it to see any log messages.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M adblockplus.gyp View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 2
Wladimir Palant
http://codereview.adblockplus.org/10977050/diff/1/adblockplus.gyp File adblockplus.gyp (right): http://codereview.adblockplus.org/10977050/diff/1/adblockplus.gyp#newcode121 adblockplus.gyp:121: 'defines': ['_DEBUG'], That's not really ABP-specific - would belong ...
July 9, 2013, 2:47 p.m. (2013-07-09 14:47:27 UTC) #1
Felix Dahlke
July 9, 2013, 3:15 p.m. (2013-07-09 15:15:52 UTC) #2
Um, yes, it actually works. I had some hiccups with regsvr32 so I guess that was
the issue, not me adding this here. Closing...

Powered by Google App Engine
This is Rietveld