Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11047004: Eliminate install directory dialog in installer (Closed)

Created:
June 18, 2013, 4:20 p.m. by Eric
Modified:
June 19, 2013, 2:46 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Untested.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M WixInstaller/custom_WixUI_InstallDir.wxs View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 5
Eric
Here you go.
June 18, 2013, 4:22 p.m. (2013-06-18 16:22:35 UTC) #1
Felix Dahlke
LGTM. Plus it works :) I committed this so we can have this in the ...
June 19, 2013, 6:44 a.m. (2013-06-19 06:44:13 UTC) #2
Felix Dahlke
Hm, Wladimir just noted that the file name doesn't really fit anymore now :P Got ...
June 19, 2013, 9:20 a.m. (2013-06-19 09:20:48 UTC) #3
Eric
On 2013/06/19 09:20:48, Felix H. Dahlke wrote: > Hm, Wladimir just noted that the file ...
June 19, 2013, 2:45 p.m. (2013-06-19 14:45:46 UTC) #4
Eric
June 19, 2013, 2:45 p.m. (2013-06-19 14:45:58 UTC) #5

          

Powered by Google App Engine
This is Rietveld