Issue 11062004: Don't use std::string in the plugin, convert when communicating with the engine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11062004: Don't use std::string in the plugin, convert when communicating with the engine (Closed)

Created:
June 27, 2013, 10:37 a.m. by Felix Dahlke

Modified:
July 2, 2013, 10:24 a.m.

Reviewers:
Oleksandr, Wladimir Palant

Visibility:
Public.

Description

As discussed. This cleans things up nicely, since the plugin can work with nothing but UTF-16 now. It's not a pure refactoring, there was one semantical change - see my comment below.

Patch Set 1 #

Total comments: 1

Created: June 27, 2013, 10:37 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -75 lines)			Patch
M	src/plugin/AdblockPlusClient.h	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	src/plugin/AdblockPlusClient.cpp	View	10 chunks	+28 lines, -20 lines	0 comments	Download
M	src/plugin/AdblockPlusDomTraverser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/plugin/PluginClass.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/plugin/PluginFilter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/plugin/PluginFilter.cpp	View	3 chunks	+3 lines, -11 lines	1 comment	Download
M	src/plugin/PluginSettings.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/plugin/PluginSettings.cpp	View	4 chunks	+6 lines, -23 lines	0 comments	Download
M	src/plugin/PluginTabBase.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/plugin/PluginUserSettings.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/plugin/PluginWbPassThrough.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Felix Dahlke

http://codereview.adblockplus.org/11062004/diff/1/src/plugin/PluginFilter.cpp File src/plugin/PluginFilter.cpp (left): http://codereview.adblockplus.org/11062004/diff/1/src/plugin/PluginFilter.cpp#oldcode640 src/plugin/PluginFilter.cpp:640: CString filter((*it).c_str()); As you can see, I didn't this. ...

June 27, 2013, 10:53 a.m. (2013-06-27 10:53:06 UTC) #1

LGTM, nice!

Expand All Messages | Collapse All Messages