Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11089006: Be more selective for the sharing fallback (Closed)

Created:
July 8, 2013, 11:12 a.m. by Wladimir Palant
Modified:
July 9, 2013, 1:45 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Be more selective for the sharing fallback

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/content/ui/firstRun.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/content/ui/firstRun.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/skin/sendReport.css View 1 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 5
Wladimir Palant
July 8, 2013, 11:12 a.m. (2013-07-08 11:12:17 UTC) #1
Thomas Greiner
LGTM (just a minor nit) http://codereview.adblockplus.org/11089006/diff/1/chrome/content/ui/firstRun.html File chrome/content/ui/firstRun.html (right): http://codereview.adblockplus.org/11089006/diff/1/chrome/content/ui/firstRun.html#newcode93 chrome/content/ui/firstRun.html:93: <a id="share-facebook" class="share-button" href="https://www.facebook.com/adblockplus" ...
July 8, 2013, 1:46 p.m. (2013-07-08 13:46:47 UTC) #2
Wladimir Palant
July 9, 2013, 12:20 p.m. (2013-07-09 12:20:20 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/11089006/diff/5001/chrome/skin/sendReport.css File chrome/skin/sendReport.css (right): http://codereview.adblockplus.org/11089006/diff/5001/chrome/skin/sendReport.css#newcode29 chrome/skin/sendReport.css:29: -moz-binding: none !important; This is an unrelated change and ...
July 9, 2013, 12:23 p.m. (2013-07-09 12:23:02 UTC) #4
Thomas Greiner
July 9, 2013, 1:45 p.m. (2013-07-09 13:45:08 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld