Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/firstRun.html

Issue 11089006: Be more selective for the sharing fallback (Closed)
Patch Set: Created July 8, 2013, 11:12 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/content/ui/firstRun.js » ('j') | chrome/content/ui/firstRun.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/firstRun.html
===================================================================
--- a/chrome/content/ui/firstRun.html
+++ b/chrome/content/ui/firstRun.html
@@ -85,23 +85,23 @@
</div>
</li>
</ul>
<footer id="social">
<h1 class="i18n_firstRun_share"></h1>
<ul>
<li>
- <a id="share-facebook" class="share-button" href="https://www.facebook.com/adblockplus" target="_blank" title="Share on Facebook"></a>
+ <a id="share-facebook" class="share-button" href="https://www.facebook.com/adblockplus" target="_blank" title="Share on Facebook" _script="https://facebook.com/plugins/like.php?"></a>
Thomas Greiner 2013/07/08 13:46:47 _script is not a standard attribute for anchor tag
</li>
<li>
- <a id="share-twitter" class="share-button" href="https://twitter.com/adblockplus" target="_blank" title="Share on Twitter"></a>
+ <a id="share-twitter" class="share-button" href="https://twitter.com/adblockplus" target="_blank" title="Share on Twitter" _script="https://platform.twitter.com/widgets.js"></a>
Thomas Greiner 2013/07/08 13:46:47 _script is not a standard attribute for anchor tag
</li>
<li>
- <a id="share-gplus" class="share-button" href="https://www.google.com/+AdblockPlus" target="_blank" title="Share on Google+"></a>
+ <a id="share-gplus" class="share-button" href="https://www.google.com/+AdblockPlus" target="_blank" title="Share on Google+" _script="https://apis.google.com/js/plusone.js"></a>
Thomas Greiner 2013/07/08 13:46:47 _script is not a standard attribute for anchor tag
</li>
</ul>
</footer>
</div>
<div id="glass-pane">
<iframe id="share-popup" scrolling="no"></iframe>
</div>
« no previous file with comments | « no previous file | chrome/content/ui/firstRun.js » ('j') | chrome/content/ui/firstRun.js » ('J')

Powered by Google App Engine
This is Rietveld