Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11095040: Don't show desktop notifications in Opera (Closed)

Created:
July 24, 2013, 12:47 p.m. by Felix Dahlke
Modified:
July 25, 2013, 10:06 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

In 1.5.2, we're requesting the notification permission and are trying to show a desktop notification, which causes errors in Opera.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M background.js View 1 chunk +2 lines, -1 line 0 comments Download
M metadata.opera View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2
Felix Dahlke
July 24, 2013, 12:49 p.m. (2013-07-24 12:49:01 UTC) #1
Wladimir Palant
July 24, 2013, 12:50 p.m. (2013-07-24 12:50:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld