Actually saving and loading the prefs

lib/prefs.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 17 matching lines @@
   data_directory: "",
   savestats: false,
   privateBrowsing: false,
   subscriptions_fallbackerrors: 5,
   subscriptions_fallbackurl: "https://adblockplus.org/getSubscription?version=%VERSION%&url=%SUBSCRIPTION%&downloadURL=%URL%&error=%ERROR%&channelStatus=%CHANNELSTATUS%&responseStatus=%RESPONSESTATUS%",
   subscriptions_autoupdate: true,
   subscriptions_exceptionsurl: "https://easylist-downloads.adblockplus.org/exceptionrules.txt",
   documentation_link: "https://adblockplus.org/redirect?link=%LINK%&lang=%LANG%",
   update_url_release: "https://update.adblockplus.org/%NAME%/update.json?id=%ID%&version=%VERSION%&app=%APP%&type=%TYPE%",
   update_url_devbuild: "https://adblockplus.org/devbuilds/%NAME%/update.json?id=%ID%&version=%VERSION%&app=%APP%&type=%TYPE%",
-  next_update_check: 0
+  next_update_check: 0,
+  statusbarasked: false
 };
 
 let values = Object.create(defaults);
 let path = _fileSystem.resolve("prefs.json");
 let listeners = [];
 let isDirty = false;
 let isSaving = false;
 
 function defineProperty(key)
 {
@@ skipping 18 matching lines @@
 {
   _fileSystem.read(path, function(result)
   {
     // prefs.json is expected to be missing, ignore errors reading file
     if (!result.error)
     {
       try
       {
         let data = JSON.parse(result.content);
         for (let key in data)
+          if (key in defaults)
             values[key] = data[key];
       }
       catch (e)
       {
         Cu.reportError(e);
       }
     }
 
     if (typeof Prefs._initListener == "function")
       Prefs._initListener();
   });
 }
 
 function save()
 {
   if (isSaving)
   {
     isDirty = true;
     return;
   }
+
   isDirty = false;
   isSaving = true;
   _fileSystem.write(path, JSON.stringify(values), function()
   {
     isSaving = false;
     if (isDirty)
       save();
   });
 }
 
 let Prefs = exports.Prefs = {
   addListener: function(listener)
   {
     if (listeners.indexOf(listener) < 0)
       listeners.push(listener);
   },
 
   removeListener: function(listener)
   {
     let index = listeners.indexOf(listener);
     if (index >= 0)
       listeners.splice(index, 1);
   },
-  save: save,
-  values: values,
 };
 
 for (let key in defaults)
   defineProperty(key);

[Wladimir Palant, 2013/07/22 06:45:47]

This is where a property is defined for each pref. You should *not* write to
values directly.

 
 load();