Actually saving and loading the prefs

Actually saving and loading the prefs

[Oleksandr, 2013-07-22 00:48:30]

I think either there was a bug in SetPref/GetPref or I've missed something - in
which case please do let me know.

[Wladimir Palant, 2013-07-22 06:45:47]

You've missed something. As I mentioned before, only preferences that have
default values will be saved - this is correct and intentional. And we've
already established that you don't really need the statusbarasked pref...

http://codereview.adblockplus.org/11175032/diff/1/lib/prefs.js
File lib/prefs.js (right):

http://codereview.adblockplus.org/11175032/diff/1/lib/prefs.js#newcode125
lib/prefs.js:125: defineProperty(key);
This is where a property is defined for each pref. You should *not* write to
values directly.

[Oleksandr, 2013-07-22 07:38:40]

I think we've decided that we don't need an "isFirstRun" pref. Don't think it
was about "statusbarasked". Or if it was - that is not how I understood it. Can
you please reason (again?) how can we live without this? We definitely don't
want to ask a user to enable the status bar after each reboot... 

On 2013/07/22 06:45:47, Wladimir Palant wrote:
> You've missed something. As I mentioned before, only preferences that have
> default values will be saved - this is correct and intentional. And we've
> already established that you don't really need the statusbarasked pref...
> 
> http://codereview.adblockplus.org/11175032/diff/1/lib/prefs.js
> File lib/prefs.js (right):
> 
> http://codereview.adblockplus.org/11175032/diff/1/lib/prefs.js#newcode125
> lib/prefs.js:125: defineProperty(key);
> This is where a property is defined for each pref. You should *not* write to
> values directly.

[Oleksandr, 2013-07-22 07:49:46]

If we do need statusbarasked, then I guess it would be like in patch set 2.
However, I have to say I don't fully follow the requirement to have the property
defined first. Seems to be limiting flexibility.

On 2013/07/22 07:38:40, Oleksandr wrote:
> I think we've decided that we don't need an "isFirstRun" pref. Don't think it
> was about "statusbarasked". Or if it was - that is not how I understood it.
Can
> you please reason (again?) how can we live without this? We definitely don't
> want to ask a user to enable the status bar after each reboot... 
> 
> On 2013/07/22 06:45:47, Wladimir Palant wrote:
> > You've missed something. As I mentioned before, only preferences that have
> > default values will be saved - this is correct and intentional. And we've
> > already established that you don't really need the statusbarasked pref...
> > 
> > http://codereview.adblockplus.org/11175032/diff/1/lib/prefs.js
> > File lib/prefs.js (right):
> > 
> > http://codereview.adblockplus.org/11175032/diff/1/lib/prefs.js#newcode125
> > lib/prefs.js:125: defineProperty(key);
> > This is where a property is defined for each pref. You should *not* write to
> > values directly.