Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11237002: Provide an XMLHttpRequest constructor if used in JS modules (Closed)

Created:
July 25, 2013, 12:35 p.m. by Wladimir Palant
Modified:
July 26, 2013, 9:37 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Provide an XMLHttpRequest constructor if used in JS modules

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M bootstrap.js.tmpl View 1 2 chunks +7 lines, -0 lines 0 comments Download
M packagerGecko.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
July 25, 2013, 12:35 p.m. (2013-07-25 12:35:23 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/11237002/diff/1/bootstrap.js.tmpl File bootstrap.js.tmpl (right): http://codereview.adblockplus.org/11237002/diff/1/bootstrap.js.tmpl#newcode26 bootstrap.js.tmpl:26: var XMLHttpRequest = Components.Constructor("@mozilla.org/xmlextras/xmlhttprequest;1", "nsIXMLHttpRequest"); Why var and not ...
July 25, 2013, 1:24 p.m. (2013-07-25 13:24:11 UTC) #2
Wladimir Palant
Uploaded a new patchset, I guess you wanted to take another look? http://codereview.adblockplus.org/11237002/diff/1/bootstrap.js.tmpl File bootstrap.js.tmpl ...
July 25, 2013, 3:43 p.m. (2013-07-25 15:43:44 UTC) #3
Felix Dahlke
July 26, 2013, 9:36 a.m. (2013-07-26 09:36:17 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld