Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11239001: Use XMLHttpRequest constructor in JS modules (Closed)

Created:
July 25, 2013, 12:36 p.m. by Wladimir Palant
Modified:
July 26, 2013, 9:38 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

This makes use of the change in http://codereview.adblockplus.org/11237002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M .hgsubstate View 1 chunk +1 line, -1 line 0 comments Download
M lib/downloader.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/io.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/objectTabs.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/synchronizer.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/ui.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
July 25, 2013, 12:36 p.m. (2013-07-25 12:36:45 UTC) #1
Felix Dahlke
I generally don't like to change code solely to make things easier to test, but ...
July 25, 2013, 1:24 p.m. (2013-07-25 13:24:09 UTC) #2
Wladimir Palant
July 25, 2013, 3:41 p.m. (2013-07-25 15:41:23 UTC) #3
On 2013/07/25 13:24:09, Felix H. Dahlke wrote:
> I generally don't like to change code solely to make things easier to test,

It's not - we should move away from using XPCOM throughout the code and
requiring non-Gecko clients to emulate it.

Powered by Google App Engine
This is Rietveld