Issue 11254007: Installation with registry keys

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11254007: Installation with registry keys

Created:
July 25, 2013, 9:57 p.m. by Eric

Modified:
June 19, 2015, 2:05 p.m.

Reviewers:

Visibility:
Public.

Description

Use installation keys to find file and directory locations. WiX source modified to write registry keys. Two projects defined in .gyp to add and remove keys. Update also includes tests and new first-run page. Developer Installation Setup 1: Execute BHO_add.reg (from Windows Explorer, say). This adds the BHO key, which is the only one for the developer install that requires UAC. Setup 2: Within Visual Studio, go into the configuration manager and uncheck the "Include in Build" box for "Developer Uninstall". (I couldn't figure out a way for gyp to do that.) After that, when the Developer Install project builds, in will write appropriate HKCU keys to use everything in source and build trees for the plugin.

Patch Set 1 #

Created: July 25, 2013, 9:57 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+340 lines, -101 lines)			Patch
M	adblockplus.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	dev_install.cmd	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	dev_query.cmd	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	dev_uninstall.cmd	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	installer/adblockplusie.wxs	View	8 chunks	+65 lines, -43 lines	0 comments	Download
A	installer/location_registry_value.wxi	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/plugin/AdblockPlusClient.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/plugin/Plugin.cpp	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/plugin/PluginUtil.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/shared/Dictionary.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/shared/Dictionary.cpp	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/shared/Utils.h	View	2 chunks	+28 lines, -1 line	0 comments	Download
M	src/shared/Utils.cpp	View	3 chunks	+151 lines, -33 lines	0 comments	Download
M	test/DictionaryTest.cpp	View	4 chunks	+38 lines, -3 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages