Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11376138: HTTPS support (Closed)

Created:
Aug. 11, 2013, 4:54 p.m. by Oleksandr
Modified:
Aug. 13, 2013, 9:54 a.m.
Visibility:
Public.

Description

HTTPS support

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M src/plugin/PluginErrorCodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/plugin/PluginMimeFilterClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/plugin/PluginMimeFilterClient.cpp View 4 chunks +25 lines, -1 line 1 comment Download

Messages

Total messages: 3
Oleksandr
Aug. 11, 2013, 4:56 p.m. (2013-08-11 16:56:13 UTC) #1
Felix Dahlke
LGTM if you address the nit http://codereview.adblockplus.org/11376138/diff/1/src/plugin/PluginMimeFilterClient.cpp File src/plugin/PluginMimeFilterClient.cpp (right): http://codereview.adblockplus.org/11376138/diff/1/src/plugin/PluginMimeFilterClient.cpp#newcode18 src/plugin/PluginMimeFilterClient.cpp:18: m_spCFHTTPS = NULL; ...
Aug. 11, 2013, 5 p.m. (2013-08-11 17:00:36 UTC) #2
Wladimir Palant
Aug. 13, 2013, 9:54 a.m. (2013-08-13 09:54:45 UTC) #3
LGTM with Felix' nit addressed (the code doesn't seem to be in the repository
yet)

Powered by Google App Engine
This is Rietveld