Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11443036: Call WriteFile even for empty messages (Closed)

Created:
Aug. 13, 2013, 10:07 a.m. by Felix Dahlke
Modified:
Aug. 13, 2013, 12:01 p.m.
Visibility:
Public.

Description

This is necessary to avoid hanging in the corresponding ReadFile calls. Before we kept the engine connections open, this just caused threads to hang indefinitely. Now that we're using just one connection, it causes the whole tab to hang indefinitely.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/shared/Communication.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Felix Dahlke
Aug. 13, 2013, 10:08 a.m. (2013-08-13 10:08:48 UTC) #1
Wladimir Palant
LGTM, let's hope that this actually works correctly in all cases. From http://msdn.microsoft.com/en-us/library/windows/desktop/aa365747%28v=vs.85%29.aspx: "A value ...
Aug. 13, 2013, 10:17 a.m. (2013-08-13 10:17:20 UTC) #2
Felix Dahlke
On 2013/08/13 10:17:20, Wladimir Palant wrote: > LGTM, let's hope that this actually works correctly ...
Aug. 13, 2013, 10:21 a.m. (2013-08-13 10:21:39 UTC) #3
Oleksandr
Aug. 13, 2013, noon (2013-08-13 12:00:25 UTC) #4
LGTM as well.

Powered by Google App Engine
This is Rietveld