Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11450010: IE6 status bar and FRP fix. Debugging info added. (Closed)

Created:
Aug. 19, 2013, 8:12 a.m. by Oleksandr
Modified:
Aug. 19, 2013, 4:14 p.m.
Visibility:
Public.

Description

IE6 status bar and FRP fix. Debugging info added.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -36 lines) Patch
M src/plugin/AdblockPlusClient.cpp View 10 chunks +22 lines, -0 lines 0 comments Download
M src/plugin/PluginClass.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/plugin/PluginClass.cpp View 21 chunks +49 lines, -35 lines 4 comments Download
M src/plugin/PluginTabBase.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/plugin/PluginTabBase.cpp View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3
Oleksandr
This took quite a while, but now IE6 works fine for me. The status bar ...
Aug. 19, 2013, 8:19 a.m. (2013-08-19 08:19:13 UTC) #1
Felix Dahlke
Nice you found it! LGTM with the nit fixed. I also wonder if some of ...
Aug. 19, 2013, 8:31 a.m. (2013-08-19 08:31:17 UTC) #2
Wladimir Palant
Aug. 19, 2013, 2:49 p.m. (2013-08-19 14:49:40 UTC) #3
LGTM with Felix's nit and mine addressed.

http://codereview.adblockplus.org/11450010/diff/1/src/plugin/PluginClass.cpp
File src/plugin/PluginClass.cpp (right):

http://codereview.adblockplus.org/11450010/diff/1/src/plugin/PluginClass.cpp#...
src/plugin/PluginClass.cpp:823: if (!CreateStatusBarPane())
This nested if isn't actually necessary, it can be merged with the one above.

Powered by Google App Engine
This is Rietveld