Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11576063: Stats processing: Add previousDownload field in addition to downloadInterval (Closed)

Created:
Sept. 5, 2013, 10:54 a.m. by Wladimir Palant
Modified:
Sept. 5, 2013, 12:58 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

The download interval field is a good human-visible parameter. However, in order to assert user counts over a random periods of time we need a difference in days. Note that this change essentially makes firstInDay, firstInWeek and firstInMonth fields redundant, these could be calculated from previousDownload if necessary.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M sitescripts/stats/bin/logprocessor.py View 1 chunk +13 lines, -0 lines 0 comments Download
M sitescripts/stats/common.py View 1 chunk +4 lines, -0 lines 0 comments Download
M sitescripts/stats/template/fileStats.html View 2 chunks +2 lines, -2 lines 0 comments Download
M sitescripts/stats/test/logprocessor.py View 6 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Sept. 5, 2013, 10:54 a.m. (2013-09-05 10:54:41 UTC) #1
Sebastian Noack
Sept. 5, 2013, 12:21 p.m. (2013-09-05 12:21:07 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld