Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 11790013: Expose string insertion functionality from i18n.js to public (Closed)

Created:
Sept. 20, 2013, 3:46 p.m. by Thomas Greiner
Modified:
Sept. 24, 2013, 2:02 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

This issue is a requirement for http://codereview.adblockplus.org/11627039/#ps23011

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M chrome/content/ui/i18n.js View 3 chunks +13 lines, -7 lines 1 comment Download

Messages

Total messages: 2
Thomas Greiner
Sept. 20, 2013, 3:51 p.m. (2013-09-20 15:51:37 UTC) #1
Wladimir Palant
Sept. 24, 2013, 12:45 p.m. (2013-09-24 12:45:46 UTC) #2
LGTM with the nit fixed.

http://codereview.adblockplus.org/11790013/diff/1/chrome/content/ui/i18n.js
File chrome/content/ui/i18n.js (right):

http://codereview.adblockplus.org/11790013/diff/1/chrome/content/ui/i18n.js#n...
chrome/content/ui/i18n.js:88: var setElementText = i18n.setElementText =
function(element, stringName, arguments)
Given that this is loaded into global context I suggest leaving out "var
setElementText" and only define this function on i18n. loadI18nStrings() can
call it via i18n object as well.

Powered by Google App Engine
This is Rietveld