Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 12326007: Fixed: Total blocked count was not saved across multiple sessions (Closed)

Created:
Oct. 2, 2013, 8:20 a.m. by Thomas Greiner
Modified:
Oct. 2, 2013, 10:22 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

stats.js was only manipulating a local reference to the stats_total setting. Prefs was unaware of this and therefore didn't mirror those changes in localStorage.

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M lib/stats.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
Thomas Greiner
Oct. 2, 2013, 8:28 a.m. (2013-10-02 08:28:18 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/12326007/diff/1/lib/stats.js File lib/stats.js (right): http://codereview.adblockplus.org/12326007/diff/1/lib/stats.js#newcode56 lib/stats.js:56: statsTotal.blocked = 1; Adding Prefs.stats_total = Prefs.stats_total; here to ...
Oct. 2, 2013, 9:26 a.m. (2013-10-02 09:26:26 UTC) #2
Thomas Greiner
I'd prefer a dedicated Prefs.refresh(key) method but that's also fine with me.
Oct. 2, 2013, 9:43 a.m. (2013-10-02 09:43:28 UTC) #3
Wladimir Palant
On 2013/10/02 09:43:28, Thomas Greiner wrote: > I'd prefer a dedicated Prefs.refresh(key) method but that's ...
Oct. 2, 2013, 10:11 a.m. (2013-10-02 10:11:27 UTC) #4
Wladimir Palant
Oct. 2, 2013, 10:11 a.m. (2013-10-02 10:11:44 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld