Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29320002: Issue 2713 - Move Nginx setup from module "rietveld" to module "codereview" (Closed)

Created:
June 23, 2015, 7:06 a.m. by mathias
Modified:
July 3, 2015, 10:42 a.m.
Reviewers:
Felix Dahlke
CC:
Fred
Visibility:
Public.

Description

Issue 2713 - Move Nginx setup from module "rietveld" to module "codereview"

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
A + modules/codereview/files/site.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
M modules/codereview/manifests/init.pp View 1 chunk +6 lines, -4 lines 0 comments Download
D modules/rietveld/files/site.conf View 1 chunk +0 lines, -8 lines 0 comments Download
M modules/rietveld/manifests/init.pp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 7
mathias
June 23, 2015, 7:07 a.m. (2015-06-23 07:07:01 UTC) #1
mathias
Now merged with #2683 and #2704
June 23, 2015, 7:53 a.m. (2015-06-23 07:53:31 UTC) #2
Felix Dahlke
On 2015/06/23 07:53:31, mathias wrote: > Now merged with #2683 and #2704 Shouldn't this review ...
July 2, 2015, 1:29 p.m. (2015-07-02 13:29:40 UTC) #3
mathias
On 2015/07/02 13:29:40, Felix Dahlke wrote: > On 2015/06/23 07:53:31, mathias wrote: > > Now ...
July 2, 2015, 2:13 p.m. (2015-07-02 14:13:53 UTC) #4
Felix Dahlke
On 2015/07/02 14:13:53, mathias wrote: > On 2015/07/02 13:29:40, Felix Dahlke wrote: > > On ...
July 2, 2015, 8:20 p.m. (2015-07-02 20:20:02 UTC) #5
mathias
Very well.
July 2, 2015, 9 p.m. (2015-07-02 21:00:20 UTC) #6
Felix Dahlke
July 2, 2015, 9:45 p.m. (2015-07-02 21:45:22 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld