Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29323001: Issue 2836 - Fix regressions from #2814 / #2835 (Closed)

Created:
July 29, 2015, 6:25 p.m. by mathias
Modified:
July 29, 2015, 9:07 p.m.
Reviewers:
Felix Dahlke
CC:
Fred
Visibility:
Public.

Description

Issue 2836 - Fix regressions from #2814 / #2835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M hiera/roles/filtermasterserver.yaml View 1 chunk +0 lines, -8 lines 0 comments Download
M modules/filtermaster/manifests/init.pp View 2 chunks +8 lines, -2 lines 0 comments Download
M modules/filtermaster/templates/sitescripts.ini.erb View 1 chunk +5 lines, -1 line 0 comments Download
A modules/private-stub/hiera/roles/filtermasterserver.yaml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2
mathias
July 29, 2015, 6:25 p.m. (2015-07-29 18:25:40 UTC) #1
Felix Dahlke
July 29, 2015, 8:36 p.m. (2015-07-29 20:36:47 UTC) #2
LGTM, although I'd prefer to simplify this again by changing the single
repository key in sitescripts that's not identical to the repo name.

Powered by Google App Engine
This is Rietveld