Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29323282: Noissue - Add hint for Windows users regarding git auto-conversion of line endings (Closed)

Created:
Aug. 5, 2015, 12:17 p.m. by Fred
Modified:
Aug. 11, 2015, 7:27 a.m.
Reviewers:
mathias, Felix Dahlke
Visibility:
Public.

Description

Noissue - Add hint for Windows users regarding git auto-conversion of line endings

Patch Set 1 #

Patch Set 2 : Changed wording #

Total comments: 1

Patch Set 3 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M README.md View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
Fred
Aug. 5, 2015, 12:17 p.m. (2015-08-05 12:17:42 UTC) #1
mathias
Thank you for the suggestion! This issue actually raises questions quite often, so I do ...
Aug. 5, 2015, 12:49 p.m. (2015-08-05 12:49:20 UTC) #2
Fred
Since this is the only "Caveat" I can think of at the moment, an own ...
Aug. 5, 2015, 1:32 p.m. (2015-08-05 13:32:26 UTC) #3
Fred
Aug. 5, 2015, 3:35 p.m. (2015-08-05 15:35:44 UTC) #4
mathias
https://codereview.adblockplus.org/29323282/diff/29323285/README.md File README.md (right): https://codereview.adblockplus.org/29323282/diff/29323285/README.md#newcode48 README.md:48: conversion if the git option `core.autocrlf` is set to ...
Aug. 10, 2015, 11:53 a.m. (2015-08-10 11:53:55 UTC) #5
Fred
Aug. 10, 2015, 1:11 p.m. (2015-08-10 13:11:05 UTC) #6
Fred
Fixed typo
Aug. 10, 2015, 2:06 p.m. (2015-08-10 14:06:45 UTC) #7
Fred
Fixed typo
Aug. 10, 2015, 2:17 p.m. (2015-08-10 14:17:25 UTC) #8
mathias
LGTM
Aug. 10, 2015, 2:21 p.m. (2015-08-10 14:21:17 UTC) #9
Felix Dahlke
Aug. 11, 2015, 7:27 a.m. (2015-08-11 07:27:02 UTC) #10
Message was sent while issue was closed.
No objections, but doesn't this affect all our Git repositories? If so, maybe we
should just add this to https://adblockplus.org/en/source#github, and link to
that prominently from the descriptions on GitHub and/or READMEs?

Powered by Google App Engine
This is Rietveld