Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29323547: Issue 2751 - Separate build and sign steps (Closed)

Created:
Aug. 13, 2015, 7:15 a.m. by Felix Dahlke
Modified:
Aug. 13, 2015, 5:20 p.m.
Reviewers:
René Jeschke
Visibility:
Public.

Description

Issue 2751 - Separate build and sign steps

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M build.py View 3 chunks +27 lines, -6 lines 1 comment Download

Messages

Total messages: 2
Felix Dahlke
Aug. 13, 2015, 7:17 a.m. (2015-08-13 07:17:07 UTC) #1
René Jeschke
Aug. 13, 2015, 8:01 a.m. (2015-08-13 08:01:52 UTC) #2
LGTM (with a nit)

https://codereview.adblockplus.org/29323547/diff/29323548/build.py
File build.py (right):

https://codereview.adblockplus.org/29323547/diff/29323548/build.py#newcode120
build.py:120: else:
Nit: this (and the next line) could be removed, as it is dead code

Powered by Google App Engine
This is Rietveld