Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/base/BrowserApp.java

Issue 29324521: Issue 2930 - Re-enable and adapt about:feedback (Closed)
Patch Set: Created Aug. 23, 2015, 6:05 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mobile/android/app/mobile.js ('k') | mobile/android/chrome/content/aboutFeedback.xhtml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mobile/android/base/BrowserApp.java
===================================================================
--- a/mobile/android/base/BrowserApp.java
+++ b/mobile/android/base/BrowserApp.java
@@ -232,9 +232,10 @@
private FindInPageBar mFindInPageBar;
private MediaCastingBar mMediaCastingBar;
- // Don't show about:feedback automatically in Adblock Browser, see
- // https://issues.adblockplus.org/ticket/2521
- private static final int FEEDBACK_LAUNCH_COUNT = 0;
+ // We'll ask for feedback after the user launches the app this many times.
+ // Mozilla did this after 15 times. In Adblock Browser, we prefer to do it
+ // a bit earlier, see: https://issues.adblockplus.org/ticket/2930.
+ private static final int FEEDBACK_LAUNCH_COUNT = 5;
// Stored value of the toolbar height, so we know when it's changed.
private int mToolbarHeight;
« no previous file with comments | « mobile/android/app/mobile.js ('k') | mobile/android/chrome/content/aboutFeedback.xhtml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld