Add Adblock Browser promotion test notification

Add Adblock Browser promotion test notification

[Felix Dahlke, 2015-09-01 10:13:47]

We're planning to launch this one this afternoon, I will also put up a review
for the adblock_browser_promotion redirect shortly.

One thing I'm not entirely sure about yet is how to best exclude devbuild users.
Seems to me that extensionMaxVersion=$latest_stable as I did in the current
patch does the trick. Users on older devbuilds would, however, see the
notification. Currently waiting for some data on how many people this are. I
will also test this some more.

[Sebastian Noack, 2015-09-01 10:37:34]

LGTM

[Sebastian Noack, 2015-09-01 10:47:45]

On 2015/09/01 10:13:47, Felix Dahlke wrote:
> One thing I'm not entirely sure about yet is how to best exclude devbuild
users.
> Seems to me that extensionMaxVersion=$latest_stable as I did in the current
> patch does the trick. Users on older devbuilds would, however, see the
> notification. Currently waiting for some data on how many people this are. I
> will also test this some more.

I don't think it's worth excluding devbuild users. We have extremely few
devbuild users compared to our total user numbers, that I wouldn't even consider
them, in particular for a test that is only rolled out to a subset of users. If
you think it's still worth excluding devbuild users, for whatever reason, I'm
fine with the approach here.

[Felix Dahlke, 2015-09-01 11:54:51]

On 2015/09/01 10:47:45, Sebastian Noack wrote:
> On 2015/09/01 10:13:47, Felix Dahlke wrote:
> > One thing I'm not entirely sure about yet is how to best exclude devbuild
> users.
> > Seems to me that extensionMaxVersion=$latest_stable as I did in the current
> > patch does the trick. Users on older devbuilds would, however, see the
> > notification. Currently waiting for some data on how many people this are. I
> > will also test this some more.
> 
> I don't think it's worth excluding devbuild users. We have extremely few
> devbuild users compared to our total user numbers, that I wouldn't even
consider
> them, in particular for a test that is only rolled out to a subset of users.
If
> you think it's still worth excluding devbuild users, for whatever reason, I'm
> fine with the approach here.

Yes you're right, it's not worth the effort. I was hoping most devbuild users
would be on devbuilds that were published after the latest release, but that's
not quite the case :(

I've also moved the start time forward to 1pm UTC, which is 3pm CEST. I've done
some more testing, including locale fallback (en-GB -> en-US and es-419 -> es,
specifically), just to be absolutely safe.

[Felix Dahlke, 2015-09-01 12:16:35]

Sebastian pointed out over IRC that Chrome uses "es" for Spanish Spanish
(es-ES), so how it was working, those users would see latin Americain Spanish.
Solved this by duplicating the latin Americain locales and changing es-ES to be
es.

Still, I think we should use the same language format (IMHO Mozilla l10n locale
codes) on all platforms here.

[Sebastian Noack, 2015-09-01 12:29:22]

I just realized that the product names "Adblock Plus" and "Adblock Browser" are
translated in some languages, where we aren't used to translate product names.
In some cases only the "Plus" or "Browser" is translated, what we didn't ever do
so far.

But since we run out of time, I have no choice other than to LGTM this. :(

[Felix Dahlke, 2015-09-01 12:44:43]

On 2015/09/01 12:29:22, Sebastian Noack wrote:
> I just realized that the product names "Adblock Plus" and "Adblock Browser"
are
> translated in some languages, where we aren't used to translate product names.
> In some cases only the "Plus" or "Browser" is translated, what we didn't ever
do
> so far.
> 
> But since we run out of time, I have no choice other than to LGTM this. :(

We'll ask the translation agency to look into that, I presume we can make such
minor changes after the test.

Pushed: https://hg.adblockplus.org/notifications/rev/4a97842bc5d4