Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: modules/notificationserver/files/site.conf

Issue 29325787: Issue 2982 - Don't send notifications to users that were in the browser notification test (Closed)
Patch Set: Created Sept. 3, 2015, 9:14 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | modules/notificationserver/manifests/init.pp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: modules/notificationserver/files/site.conf
===================================================================
--- a/modules/notificationserver/files/site.conf
+++ b/modules/notificationserver/files/site.conf
@@ -7,6 +7,14 @@
location /notification.json
{
+ # Users that were in the browser notification test shouldn't see the same
+ # thing again, so they're not seeing any notifications for now.
+ # See https://issues.adblockplus.org/ticket/2982.
+ if ($arg_lastVersion ~ "-2/[1-3]")
+ {
+ rewrite ^ /empty-notification.json last;
+ }
+
fastcgi_pass unix:/tmp/multiplexer-fastcgi.sock;
include /etc/nginx/fastcgi_params;
fastcgi_cache notification;
@@ -14,3 +22,8 @@
fastcgi_cache_valid any 1m;
fastcgi_cache_lock on;
}
+
+location /empty-notification.json
+{
+ root /var/www;
+}
« no previous file with comments | « no previous file | modules/notificationserver/manifests/init.pp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld