Issue 29325787: Issue 2982 - Don't send notifications to users that were in the browser notification test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29325787: Issue 2982 - Don't send notifications to users that were in the browser notification test (Closed)

Created:
Sept. 3, 2015, 9:14 a.m. by Felix Dahlke

Modified:
Sept. 3, 2015, 2:43 p.m.

Reviewers:
mathias, Wladimir Palant

Visibility:
Public.

Issue 2982 - Don't send notifications to users that were in the browser notification test

Created: Sept. 3, 2015, 9:14 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	modules/notificationserver/files/site.conf	View		2 chunks	+13 lines, -0 lines	0 comments	Download
	M	modules/notificationserver/manifests/init.pp	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 3

Felix Dahlke

Note that I'm not planning to push this until shortly before we put the real ...

Sept. 3, 2015, 9:17 a.m. (2015-09-03 09:17:53 UTC) #1

mathias

LGTM. How long do you intend to keep this? Or which event in particular will ...

Sept. 3, 2015, 9:22 a.m. (2015-09-03 09:22:39 UTC) #2

Felix Dahlke

Sept. 3, 2015, 2:43 p.m. (2015-09-03 14:43:13 UTC) #3

This is too hacky, I've modified https://issues.adblockplus.org/ticket/2982 to
implement a better approach with similarly low effort.