Issue 616 - Add some tests for generic hide + block

Issue 616 - Add some tests for generic hide + block

(testcases.adblockplus.org)

[kzar, 2015-09-05 15:36:53]

Patch Set 1

https://codereview.adblockplus.org/29325987/diff/29325988/pages/testcases/gen...
File pages/testcases/generic/index.html (right):

https://codereview.adblockplus.org/29325987/diff/29325988/pages/testcases/gen...
pages/testcases/generic/index.html:11: <iframe id="iframe"></iframe>
I've created this page so that we can load test cases inside a frame with a
different domain (www.testcases.adblockplus.org as opposed to
testcases.adblockplus.org). I wanted to do this to make sure that the filters
were applying recursively through frames.

I wanted to place this file in pages/index.html so that it could be easily
re-used elsewhere but unfortunately that wasn't possible with the filter
matching tests I wanted to do. That said we could still copy this file and place
it in other testcases directories if we need to test recursive matching
elsewhere. (Perhaps using an include to reduce duplication.)

[rossg, 2015-09-10 11:06:09]

Possible bug.

https://codereview.adblockplus.org/29325987/diff/29325988/pages/testcases/gen...
File pages/testcases/generic/index.html (right):

https://codereview.adblockplus.org/29325987/diff/29325988/pages/testcases/gen...
pages/testcases/generic/index.html:11: <iframe id="iframe"></iframe>
On 2015/09/05 15:36:53, kzar wrote:
> *snip*

I applied the patch set successfully, however sometimes the pages do not load
correctly for me. They fail because they are attempting to lookup
www.www.testcases.adblockplus.org or www.www.www.testcases.adblockplus.org. So
far I figured out the failure to load is due to links on the main testpages
index page having www. in front of them, leading to the replace creating the
double or triple www. links. However sometimes when loading the index page, it's
fine.

I'm testing with both testpages.adblockplus.org and
www.testpages.adblockplus.org pointing at a local server at 127.0.0.1:5000.

[kzar, 2015-09-10 11:12:07]

Patch Set 2 : Fixed www.www... recursion issue

https://codereview.adblockplus.org/29325987/diff/29325988/pages/testcases/gen...
File pages/testcases/generic/index.html (right):

https://codereview.adblockplus.org/29325987/diff/29325988/pages/testcases/gen...
pages/testcases/generic/index.html:11: <iframe id="iframe"></iframe>
On 2015/09/10 11:06:08, rossg wrote:
> On 2015/09/05 15:36:53, kzar wrote:
> > *snip*
> 
> I applied the patch set successfully, however sometimes the pages do not load
> correctly for me. They fail because they are attempting to lookup
> http://www.www.testcases.adblockplus.org or
http://www.www.www.testcases.adblockplus.org. So
> far I figured out the failure to load is due to links on the main testpages
> index page having www. in front of them, leading to the replace creating the
> double or triple www. links. However sometimes when loading the index page,
it's
> fine.
> 
> I'm testing with both http://testpages.adblockplus.org and
> http://www.testpages.adblockplus.org pointing at a local server at
127.0.0.1:5000.
> 

My mistake, should be fixed now for both www.testpages... and testpages...

[rossg, 2015-09-10 12:08:23]

On 2015/09/10 11:12:07, kzar wrote:
> Patch Set 2 : Fixed http://www.www... recursion issue
> 
>
https://codereview.adblockplus.org/29325987/diff/29325988/pages/testcases/gen...
> File pages/testcases/generic/index.html (right):
> 
>
https://codereview.adblockplus.org/29325987/diff/29325988/pages/testcases/gen...
> pages/testcases/generic/index.html:11: <iframe id="iframe"></iframe>
> On 2015/09/10 11:06:08, rossg wrote:
> > On 2015/09/05 15:36:53, kzar wrote:
> > > *snip*
> > 
> > I applied the patch set successfully, however sometimes the pages do not
load
> > correctly for me. They fail because they are attempting to lookup
> > http://www.www.testcases.adblockplus.org or
> http://www.www.www.testcases.adblockplus.org. So
> > far I figured out the failure to load is due to links on the main testpages
> > index page having www. in front of them, leading to the replace creating the
> > double or triple www. links. However sometimes when loading the index page,
> it's
> > fine.
> > 
> > I'm testing with both http://testpages.adblockplus.org and
> > http://www.testpages.adblockplus.org pointing at a local server at
> 127.0.0.1:5000.
> > 
> 
> My mistake, should be fixed now for both http://www.testpages... and
testpages...

Noticed something else:

URL is wrong after visiting a generic page. Not sure why this is caused?

1. Applied new patch.
2. Navigated to testpages index page and selected a generic test.
3. Generic test page loads okay. Selected the ABP Test Pages header link.
4. Now back at the testpages index page (testpages.adblockplus.org), but the URL
in the address bar is now
http://testpages.adblockplus.org/en/testcases/generic/#01
5. Selected a non-generic test.
6. URL is still http://testpages.adblockplus.org/en/testcases/generic/#01

[kzar, 2015-09-10 13:19:49]

Patch Set 3 : Ensure we break out of iFrame!

Whoops, well spotted. I forgot to add target="_top" to the relevant links to
make sure the user would break out of the iframe again. Done.

[rossg, 2015-09-11 13:18:53]

On 2015/09/10 13:19:49, kzar wrote:
> Patch Set 3 : Ensure we break out of iFrame!
> 
> Whoops, well spotted. I forgot to add target="_top" to the relevant links to
> make sure the user would break out of the iframe again. Done.

Fixed. LGTM now.

[kzar, 2015-09-11 14:16:57]

Patch Set 4 : Adjust for new dimensions of test + fail images

[rossg, 2015-09-14 11:09:54]

On 2015/09/11 14:16:57, kzar wrote:
> Patch Set 4 : Adjust for new dimensions of test + fail images

LGTM again.