Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29326028: Issue 2999 - Integrate web::server SSL parameters with Hiera (Closed)

Created:
Sept. 7, 2015, 10:42 a.m. by mathias
Modified:
Sept. 8, 2015, 7:09 a.m.
Reviewers:
Fred
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 2999 - Integrate web::server SSL parameters with Hiera

Patch Set 1 #

Patch Set 2 : Issue 2999 - Now the correct patch-set #

Patch Set 3 : Issue 2999 - Recognize HTTP/S when dealing with host aliases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
M modules/web/manifests/server.pp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M modules/web/templates/global.conf.erb View 1 2 1 chunk +27 lines, -18 lines 0 comments Download

Messages

Total messages: 5
mathias
Sept. 7, 2015, 10:42 a.m. (2015-09-07 10:42:45 UTC) #1
mathias
Sept. 7, 2015, 10:46 a.m. (2015-09-07 10:46:49 UTC) #2
Fred
As discussed, this patch won't work for web servers that don't have (don't need) SSL ...
Sept. 7, 2015, 1:10 p.m. (2015-09-07 13:10:57 UTC) #3
mathias
Sept. 7, 2015, 1:21 p.m. (2015-09-07 13:21:35 UTC) #4
Fred
Sept. 7, 2015, 2:21 p.m. (2015-09-07 14:21:23 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld