Issue 29327585: Issue 3050 - Fix broken AA links on google.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29327585: Issue 3050 - Fix broken AA links on google.com (Closed)

Created:
Sept. 12, 2015, 6:49 a.m. by Felix Dahlke

Modified:
Sept. 12, 2015, 6:57 a.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Issue 3050 - Fix broken AA links on google.com This is most definitely a temporary workaround. In this particular case the very generous whitelisting rule is OK, since there's nothing that's not an Acceptable Ad on google.com anyway. But we have to find a better workaround to replace the specific exception rules not working here. And we surely shouldn't have to manually modify the rules, this needs to be covered in the conversion script.

Patch Set 1 #

Created: Sept. 12, 2015, 6:49 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	AdblockPlusSafariExtension/easylist_with_acceptable_ads.json	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sebastian Noack

Well, this is not a solution but a workaround. Anyway, LGTM. But please let's figure ...

Sept. 12, 2015, 6:56 a.m. (2015-09-12 06:56:50 UTC) #1

Felix Dahlke

Sept. 12, 2015, 6:57 a.m. (2015-09-12 06:57:52 UTC) #2

On 2015/09/12 06:56:50, Sebastian Noack wrote:
> Well, this is not a solution but a workaround. Anyway, LGTM. But please let's
> figure out what is actually causing it.

Absolutely, I'll keep the issue open.

Expand All Messages | Collapse All Messages