Issue 29328514: Issue 3103 - Introduce type logrotate::config

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29328514: Issue 3103 - Introduce type logrotate::config (Closed)

Created:
Sept. 23, 2015, 6:47 a.m. by mathias

Modified:
Oct. 1, 2015, 12:58 p.m.

Reviewers:
Fred

CC:
Felix Dahlke

Visibility:
Public.

Description

Issue 3103 - Introduce type logrotate::config

Patch Set 1 #

Total comments: 1

Created: Sept. 23, 2015, 6:47 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -0 lines)			Patch
	A	modules/logrotate/manifests/config.pp	View		1 chunk	+57 lines, -0 lines	1 comment	Download
	M	modules/logrotate/manifests/init.pp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Fred

LGTM, except for the $source parameter issue already discussed in person. https://codereview.adblockplus.org/29328514/diff/29328515/modules/logrotate/manifests/config.pp File modules/logrotate/manifests/config.pp (right): ...

Sept. 29, 2015, 11:33 a.m. (2015-09-29 11:33:51 UTC) #2

mathias

Sept. 29, 2015, 2:47 p.m. (2015-09-29 14:47:35 UTC) #3

On 2015/09/29 11:33:51, Fred wrote:
> LGTM, except for the $source parameter issue already discussed in person.
> 
>
https://codereview.adblockplus.org/29328514/diff/29328515/modules/logrotate/m...
> File modules/logrotate/manifests/config.pp (right):
> 
>
https://codereview.adblockplus.org/29328514/diff/29328515/modules/logrotate/m...
> modules/logrotate/manifests/config.pp:43: $source = undef,
> This $source parameter is not being used any further below.

diff --git a/modules/logrotate/manifests/config.pp
b/modules/logrotate/manifests/config.pp
index d1f9522..cf0f158 100644
--- a/modules/logrotate/manifests/config.pp
+++ b/modules/logrotate/manifests/config.pp
@@ -53,5 +53,6 @@ define logrotate::config (
     mode => 0644,
     owner => 'root',
     path => "/etc/logrotate.d/$name",
+    source => $source,
   }
 }

Expand All Messages | Collapse All Messages