Issue 29328694: Issue 3133 - Always perform a clobber before building

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29328694: Issue 3133 - Always perform a clobber before building (Closed)

Created:
Sept. 29, 2015, 12:42 p.m. by Felix Dahlke

Modified:
Sept. 29, 2015, 3:42 p.m.

Reviewers:
René Jeschke

Visibility:
Public.

Description

Issue 3133 - Always perform a clobber before building

Patch Set 1 #

Total comments: 2

Created: Sept. 29, 2015, 12:42 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	build.py	View		2 chunks	+9 lines, -9 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

René Jeschke

LGTM https://codereview.adblockplus.org/29328694/diff/29328695/build.py File build.py (right): https://codereview.adblockplus.org/29328694/diff/29328695/build.py#newcode67 build.py:67: subprocess.check_call([os.path.join(ABB_PATH, "mach"), "clobber"], Nit: there has been an ...

Sept. 29, 2015, 3:19 p.m. (2015-09-29 15:19:41 UTC) #2

Felix Dahlke

https://codereview.adblockplus.org/29328694/diff/29328695/build.py File build.py (right): https://codereview.adblockplus.org/29328694/diff/29328695/build.py#newcode67 build.py:67: subprocess.check_call([os.path.join(ABB_PATH, "mach"), "clobber"], On 2015/09/29 15:19:41, René Jeschke wrote: ...

Sept. 29, 2015, 3:20 p.m. (2015-09-29 15:20:32 UTC) #3

René Jeschke

Sept. 29, 2015, 3:22 p.m. (2015-09-29 15:22:33 UTC) #4

On 2015/09/29 15:20:32, Felix Dahlke wrote:
> https://codereview.adblockplus.org/29328694/diff/29328695/build.py
> File build.py (right):
> 
> https://codereview.adblockplus.org/29328694/diff/29328695/build.py#newcode67
> build.py:67: subprocess.check_call([os.path.join(ABB_PATH, "mach"),
"clobber"],
> On 2015/09/29 15:19:41, René Jeschke wrote:
> > Nit: there has been an empty line here, now it's gone. Intended or accident?
> 
> Intended, but no strong opinion :P

Yeah, fine with me either way :-)

Expand All Messages | Collapse All Messages