Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29328863: Issue 3168 - Add a script for generating new content blocker lists (Closed)

Created:
Oct. 6, 2015, 2:38 p.m. by Felix Dahlke
Modified:
Oct. 13, 2015, 11:50 a.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3168 - Add a script for generating new content blocker lists

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed .hgignore - won't be needed #

Patch Set 3 : Point to the correct revisions in dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -0 lines) Patch
A dependencies View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A ensure_dependencies.py View 1 chunk +341 lines, -0 lines 0 comments Download
A generate_lists.py View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Felix Dahlke
While we should probably eventually move this logic to the sitescripts repository, for now I'd ...
Oct. 6, 2015, 3:13 p.m. (2015-10-06 15:13:25 UTC) #1
Sebastian Noack
Oct. 13, 2015, 11:40 a.m. (2015-10-13 11:40:01 UTC) #2
As discussed on IRC and in the other review, I don't think this simple script
deserves to become a dedicated repository. For reference, there is currently a
different version of this script, without ensure_dependencies.py, under review.
Therefore NOT LGTM.

Powered by Google App Engine
This is Rietveld