Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29328921: Issue 2844 - cosmetic fixes and adjustments to ABP for Microsoft Edge subscription page (Closed)

Created:
Oct. 7, 2015, 4:46 p.m. by saroyanm
Modified:
Oct. 8, 2015, 12:47 p.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

This review contain fixes to current issues: * Translation flag was shown next to Edge Icon. * On Firefox the bullet points in English version of homepage were pushed below the subscription form. * Invalid and Error messages were pushing the form upon bullet points. * Some consistency changes.

Patch Set 1 #

Patch Set 2 : remove bullet point #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
M includes/index.tmpl View 2 chunks +18 lines, -13 lines 0 comments Download
M settings.ini View 1 chunk +1 line, -0 lines 0 comments Download
M static/css/index.css View 2 chunks +16 lines, -3 lines 0 comments Download
M static/css/index-desktop.css View 1 1 chunk +5 lines, -0 lines 0 comments Download
M static/js/index.js View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4
saroyanm
Oleksandr can you please have a look.
Oct. 7, 2015, 4:51 p.m. (2015-10-07 16:51:48 UTC) #1
Oleksandr
The Microsoft Edge page looks really bad on pretty much any language other than English. ...
Oct. 8, 2015, 12:41 a.m. (2015-10-08 00:41:03 UTC) #2
saroyanm
Uploaded a new patch I've removed first bullet point which has nothing to do with ...
Oct. 8, 2015, 10:39 a.m. (2015-10-08 10:39:36 UTC) #3
Oleksandr
Oct. 8, 2015, 10:52 a.m. (2015-10-08 10:52:34 UTC) #4
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld