Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329018: Issue 3128 - The default search engine is removed if it was one of those removed by issue 3047 (moz… (Closed)

Created:
Oct. 9, 2015, 1:24 p.m. by René Jeschke
Modified:
Oct. 12, 2015, 6:58 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 3128 - The default search engine is removed if it was one of those removed by issue 3047 (moz…

Patch Set 1 #

Patch Set 2 : Skipping writing back of 'list.txt' #

Total comments: 2

Patch Set 3 : Removed list.txt write back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M mozharness/abb/transform_locales.py View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4
René Jeschke
Oct. 9, 2015, 1:28 p.m. (2015-10-09 13:28:23 UTC) #1
Felix Dahlke
https://codereview.adblockplus.org/29329018/diff/29329026/mozharness/abb/transform_locales.py File mozharness/abb/transform_locales.py (right): https://codereview.adblockplus.org/29329018/diff/29329026/mozharness/abb/transform_locales.py#newcode142 mozharness/abb/transform_locales.py:142: # We're skipping this step, though I want to ...
Oct. 12, 2015, 11:20 a.m. (2015-10-12 11:20:18 UTC) #2
René Jeschke
https://codereview.adblockplus.org/29329018/diff/29329026/mozharness/abb/transform_locales.py File mozharness/abb/transform_locales.py (right): https://codereview.adblockplus.org/29329018/diff/29329026/mozharness/abb/transform_locales.py#newcode142 mozharness/abb/transform_locales.py:142: # We're skipping this step, though I want to ...
Oct. 12, 2015, 12:59 p.m. (2015-10-12 12:59:59 UTC) #3
Felix Dahlke
Oct. 12, 2015, 6:30 p.m. (2015-10-12 18:30:01 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld