mozharness/abb/transform_locales.py - Issue 29329018: Issue 3128 - The default search engine is removed if it was one of those removed by issue 3047 (moz…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: mozharness/abb/transform_locales.py

Issue 29329018: Issue 3128 - The default search engine is removed if it was one of those removed by issue 3047 (moz… (Closed)

Patch Set: Skipping writing back of 'list.txt' Created Oct. 9, 2015, 4:38 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: mozharness/abb/transform_locales.py

diff --git a/mozharness/abb/transform_locales.py b/mozharness/abb/transform_locales.py

index 24abae7320b550b1657c557025246be5b12c29af..9ba31fb61d308ce0656f374b9289014977b48031 100644

--- a/mozharness/abb/transform_locales.py

+++ b/mozharness/abb/transform_locales.py

@@ -136,11 +136,14 @@ def _transform_locale(locale, path, logger):

props.append("browser.search.defaultenginename=%s" % engine_order[0])

# Append search engine order

- for i in range(0, min(3, len(engine_order))):

+ for i in range(0, min(5, len(engine_order))):

props.append("browser.search.order.%d=%s" % (i + 1, engine_order[i]))

+ # We're skipping this step, though I want to have that line included here,

Felix Dahlke 2015/10/12 11:20:18 Why keep the line? We can retrieve it from hg log

René Jeschke 2015/10/12 12:59:59 Done.

+ # so I only commented out writing back of list.txt.

+ # See https://issues.adblockplus.org/ticket/3128

# Write back list.txt

- _write_lines(list_file_path, engine_ids)

+ # _write_lines(list_file_path, engine_ids)

# Write back region.properties

_write_lines(region_file_path, props)

« no previous file with comments | « no previous file | no next file » | no next file with comments »