Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329141: Issue 3205 - update ABB appstore redirection link (Closed)

Created:
Oct. 15, 2015, 9:15 a.m. by saroyanm
Modified:
Oct. 15, 2015, 10:01 a.m.
Reviewers:
mathias
CC:
Felix Dahlke, simona
Visibility:
Public.

Description

The link is generated using iTunes link maker: http://linkmaker.itunes.apple.com/en-us/details/1015653330

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M modules/web/templates/adblockplus.org.conf.erb View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 4
saroyanm
@Matze can you please have a look ?
Oct. 15, 2015, 9:19 a.m. (2015-10-15 09:19:12 UTC) #1
mathias
Looks good, one open question though: https://codereview.adblockplus.org/29329141/diff/29329142/modules/web/templates/adblockplus.org.conf.erb File modules/web/templates/adblockplus.org.conf.erb (right): https://codereview.adblockplus.org/29329141/diff/29329142/modules/web/templates/adblockplus.org.conf.erb#newcode140 modules/web/templates/adblockplus.org.conf.erb:140: rewrite ^ https://geo.itunes.apple.com/us/app/adblock-browser-best-ad-blocker/id1015653330?mt=8? ...
Oct. 15, 2015, 9:37 a.m. (2015-10-15 09:37:34 UTC) #2
saroyanm
https://codereview.adblockplus.org/29329141/diff/29329142/modules/web/templates/adblockplus.org.conf.erb File modules/web/templates/adblockplus.org.conf.erb (right): https://codereview.adblockplus.org/29329141/diff/29329142/modules/web/templates/adblockplus.org.conf.erb#newcode140 modules/web/templates/adblockplus.org.conf.erb:140: rewrite ^ https://geo.itunes.apple.com/us/app/adblock-browser-best-ad-blocker/id1015653330?mt=8? redirect; On 2015/10/15 09:37:34, mathias wrote: ...
Oct. 15, 2015, 9:47 a.m. (2015-10-15 09:47:04 UTC) #3
mathias
Oct. 15, 2015, 9:58 a.m. (2015-10-15 09:58:00 UTC) #4
LGTM. Thank you for the explanation!

Powered by Google App Engine
This is Rietveld