Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329760: Issue 3260 - Remove expression closure from build tools (Closed)

Created:
Nov. 5, 2015, 10:55 a.m. by tschuster
Modified:
Dec. 21, 2017, 10:48 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 3260 - Remove expression closure from build tools

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M lib/prefs.js View 3 chunks +36 lines, -9 lines 2 comments Download

Messages

Total messages: 3
tschuster
Nov. 5, 2015, 10:56 a.m. (2015-11-05 10:56:07 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29329760/diff/29329761/lib/prefs.js File lib/prefs.js (right): https://codereview.adblockplus.org/29329760/diff/29329761/lib/prefs.js#newcode50 lib/prefs.js:50: }); I'd really prefer an arrow function here instead ...
Nov. 5, 2015, 11:25 a.m. (2015-11-05 11:25:16 UTC) #2
Wladimir Palant
Dec. 16, 2015, 11:02 a.m. (2015-12-16 11:02:05 UTC) #3
The relevant changes landed in #3418 already, feel free to close this review and
the corresponding issue.

Powered by Google App Engine
This is Rietveld