Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/filters-filterview.js

Issue 29329848: Issue 3129/3144 - Don`t let the findbar intercept keyboard events when editing filters (Closed)
Patch Set: Created Nov. 6, 2015, 8:30 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/filters-filterview.js
===================================================================
--- a/chrome/content/ui/filters-filterview.js
+++ b/chrome/content/ui/filters-filterview.js
@@ -657,16 +657,22 @@ var FilterView =
let columns = this.boxObject.columns;
for (let i = 0; i < columns.length; i++)
if (columns[i].element.hasAttribute("sortDirection"))
this.sortBy(columns[i].id, columns[i].element.getAttribute("sortDirection"));
this.refresh(true);
}
+
+ // Stop propagation of keypress events so that these aren't intercepted by
+ // the findbar.
+ this.treeElement.inputField.addEventListener("keypress", event => {
+ event.stopPropagation()
Thomas Greiner 2015/11/09 14:43:41 Detail: Missing semicolon.
Wladimir Palant 2015/11/09 15:03:49 Fixed in the patch I pushed.
+ }, false);
},
selection: null,
get rowCount() this.data.length,
getCellText: function(row, col)
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld