Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29329913: Issue 3296 - Enable ia32/x86 Android builds (Closed)

Created:
Nov. 10, 2015, 11:39 a.m. by René Jeschke
Modified:
Nov. 10, 2015, 12:42 p.m.
Reviewers:
Felix Dahlke
CC:
sergei
Visibility:
Public.

Description

Issue 3296 - Enable ia32/x86 Android builds

Patch Set 1 #

Total comments: 2

Patch Set 2 : Column alignment, moved a var def #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M Makefile View 1 2 chunks +30 lines, -8 lines 0 comments Download
M libadblockplus.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
René Jeschke
Nov. 10, 2015, 11:39 a.m. (2015-11-10 11:39:42 UTC) #1
Felix Dahlke
Looks good, just some nits. https://codereview.adblockplus.org/29329913/diff/29329914/Makefile File Makefile (right): https://codereview.adblockplus.org/29329913/diff/29329914/Makefile#newcode4 Makefile:4: ANDROID_PARAMETERS = OS=android No ...
Nov. 10, 2015, 11:50 a.m. (2015-11-10 11:50:46 UTC) #2
René Jeschke
https://codereview.adblockplus.org/29329913/diff/29329914/Makefile File Makefile (right): https://codereview.adblockplus.org/29329913/diff/29329914/Makefile#newcode4 Makefile:4: ANDROID_PARAMETERS = OS=android On 2015/11/10 11:50:46, Felix Dahlke wrote: ...
Nov. 10, 2015, 11:55 a.m. (2015-11-10 11:55:53 UTC) #3
Felix Dahlke
Nov. 10, 2015, 12:14 p.m. (2015-11-10 12:14:29 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld