Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29330725: Noissue - Document the new $generichide and $genericblock filter options (Closed)

Created:
Nov. 24, 2015, 10:15 a.m. by kzar
Modified:
Nov. 24, 2015, 11:26 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Noissue - Document the new $generichide and $genericblock filter options

Patch Set 1 #

Patch Set 2 : Use "whereas" consistently #

Total comments: 4

Patch Set 3 : Add commas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M pages/filters.html View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
Nov. 24, 2015, 10:16 a.m. (2015-11-24 10:16:32 UTC) #1
kzar
Patch Set 2 : Use "whereas" consistently
Nov. 24, 2015, 10:22 a.m. (2015-11-24 10:22:31 UTC) #2
Wladimir Palant
LGTM with the nits addressed. https://codereview.adblockplus.org/29330725/diff/29330728/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29330725/diff/29330728/pages/filters.html#newcode254 pages/filters.html:254: <p>{{generic-specific-explanation-p2 We classify a ...
Nov. 24, 2015, 11:15 a.m. (2015-11-24 11:15:38 UTC) #3
kzar
Nov. 24, 2015, 11:18 a.m. (2015-11-24 11:18:30 UTC) #4
Patch Set 3 : Add commas

https://codereview.adblockplus.org/29330725/diff/29330728/pages/filters.html
File pages/filters.html (right):

https://codereview.adblockplus.org/29330725/diff/29330728/pages/filters.html#...
pages/filters.html:254: <p>{{generic-specific-explanation-p2 We classify a
filter to be <strong>specific</strong> if it matches one or more domains or
matches a sitekey. If a filter has no domains specified (or only domain
exceptions) and no sitekey then it counts as <strong>generic</strong>. For
example <code><fix>example.com##div.textad</fix></code> is a specific filter,
whereas both <code><fix>##div.textad</fix></code> and
<code><fix>~example.com##div.textad</fix></code> are generic.}}</p>
On 2015/11/24 11:15:38, Wladimir Palant wrote:
> Nit: comma after "For example"

Done.

https://codereview.adblockplus.org/29330725/diff/29330728/pages/filters.html#...
pages/filters.html:255: <p>{{generic-specific-explanation-p3 Note that with
blocking rules the domain must be specified under the $domain option for them to
be considered specific. For example <code><fix>||example.com^</fix></code> is
considered generic whereas <code><fix>*/ads/*$domain=example.com</fix></code> is
site-specific.}}</p>
On 2015/11/24 11:15:38, Wladimir Palant wrote:
> Same here.

Done.

Powered by Google App Engine
This is Rietveld