Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29330735: Issue 3346 - Remove edge subscription form (Closed)

Created:
Nov. 24, 2015, 4:38 p.m. by saroyanm
Modified:
Nov. 26, 2015, 9:29 a.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 3346 - Remove edge subscription form

Patch Set 1 #

Patch Set 2 : Add replacement message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -241 lines) Patch
M includes/index.tmpl View 1 2 chunks +4 lines, -25 lines 0 comments Download
M static/css/index.css View 1 2 chunks +6 lines, -62 lines 0 comments Download
M static/css/index-desktop.css View 1 2 chunks +10 lines, -12 lines 0 comments Download
M static/css/index-mobile.css View 1 3 chunks +6 lines, -17 lines 0 comments Download
M static/js/index.js View 2 chunks +0 lines, -125 lines 0 comments Download

Messages

Total messages: 6
saroyanm
Oleksandr can you please have a look when you have time please.
Nov. 24, 2015, 4:39 p.m. (2015-11-24 16:39:35 UTC) #1
Oleksandr
I think this results in a confusion on mobile. On desktop the "Coming soon" image ...
Nov. 25, 2015, 2:36 a.m. (2015-11-25 02:36:50 UTC) #2
saroyanm
On 2015/11/25 02:36:50, Oleksandr wrote: > I think this results in a confusion on mobile. ...
Nov. 25, 2015, 10:26 a.m. (2015-11-25 10:26:19 UTC) #3
saroyanm
@Oleksandr I've uploaded new patch, the message was aligned with Lisa and also aligned with ...
Nov. 25, 2015, 5:15 p.m. (2015-11-25 17:15:56 UTC) #4
Oleksandr
I don't particularly like it, but LGTM :)
Nov. 25, 2015, 6:53 p.m. (2015-11-25 18:53:32 UTC) #5
saroyanm
Nov. 26, 2015, 9:26 a.m. (2015-11-26 09:26:21 UTC) #6
On 2015/11/25 18:53:32, Oleksandr wrote:
> I don't particularly like it, but LGTM :)

Yes it's pity that we had to remove the form, hopefully the issue can be fixed
and we can have it back.

Powered by Google App Engine
This is Rietveld