Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29332527: Issue 3404 - Add platform directory to devenv path (Closed)

Created:
Dec. 10, 2015, 8:05 p.m. by kzar
Modified:
Jan. 27, 2016, 1:53 p.m.
Visibility:
Public.

Description

Issue 3404 - Add platform directory to devenv path

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build.py View 1 chunk +1 line, -1 line 0 comments Download
M packager.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
Dec. 10, 2015, 8:07 p.m. (2015-12-10 20:07:05 UTC) #1
Sebastian Noack
I'm undecided on this one. As discussed internally, I prefer to just get rid of ...
Dec. 12, 2015, 12:42 a.m. (2015-12-12 00:42:25 UTC) #2
Wladimir Palant
In general, I agree that this is useful. As to the implementation, this looks like ...
Jan. 25, 2016, 2:25 p.m. (2016-01-25 14:25:38 UTC) #3
kzar
Jan. 27, 2016, 1:53 p.m. (2016-01-27 13:53:29 UTC) #4
On 2016/01/25 14:25:38, Wladimir Palant wrote:
> In general, I agree that this is useful. As to the implementation, this looks
> like it will fail if the devenv directory doesn't exist already. Also, I'd
> probably prefer devenv.chrome and devenv.safari rather than more directory
> nesting.

Sure, makes sense. Sorry I need to close this review and open a new one as
Rietveld is getting very confused since I've rebased.

Powered by Google App Engine
This is Rietveld