Issue 3307 - Introduce class adblockplus::log::rotation

Note that this patch-set is based on the one proposed for Issue 3306 (see https://codereview.adblockplus.org/29333248/).
Below please find a usage example with an existing Hiera/role YAML file, in order to illustrate the purpose despite no entity being configured to make use of the new roations just yet. This is the very patch that has been used to test this change-set.

--- >B --- *snip* --- >B ---

diff --git a/hiera/roles/web/adblockbrowser.yaml b/hiera/roles/web/adblockbrowser.yaml
index 10c6aff..57a4d51 100644
--- a/hiera/roles/web/adblockbrowser.yaml
+++ b/hiera/roles/web/adblockbrowser.yaml
@@ -1,4 +1,5 @@
 classes:
+  adblockplus::log:
   statsclient:
   web::server:
     vhost: adblockbrowser.org
@@ -14,21 +15,12 @@ classes:
     multiplexer_locations:
       - /sendInstallationLink

-logrotate::config:
+adblockplus::log::rotations:
   adblockbrowser_feedback_data:
-    content: |
-      /var/log/nginx/adblockbrowser_feedback {
-        daily
-        rotate 30
-        compress
-        missingok
-        nodateext
-        sharedscripts
-        postrotate
-          [ ! -f /var/run/nginx.pid ] || kill -USR1 `cat /var/run/nginx.pid`
-        endscript
-      }
-    ensure: 'present'
+    path: "/var/log/nginx/adblockbrowser_feedback"
+    postrotate:
+      - "[ ! -f /var/run/nginx.pid ] || kill -USR1 `cat /var/run/nginx.pid`"
+    upload: true

 sitescripts::configfragments:
   installation_link:

[Fred, 2016-01-18 17:44:40]

LGTM