Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333430: Issue 3508 - Introduce class adblockplus::user (Closed)

Created:
Jan. 13, 2016, 12:31 p.m. by mathias
Modified:
Jan. 13, 2016, 7:04 p.m.
Reviewers:
Fred
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 3508 - Introduce class adblockplus::user

Patch Set 1 #

Total comments: 2

Patch Set 2 : Issue 3508 - Fix typo in adblockplus::user documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
M modules/adblockplus/manifests/init.pp View 2 chunks +22 lines, -1 line 0 comments Download
A modules/adblockplus/manifests/user.pp View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mathias
Jan. 13, 2016, 12:31 p.m. (2016-01-13 12:31:51 UTC) #1
Fred
https://codereview.adblockplus.org/29333430/diff/29333431/modules/adblockplus/manifests/user.pp File modules/adblockplus/manifests/user.pp (right): https://codereview.adblockplus.org/29333430/diff/29333431/modules/adblockplus/manifests/user.pp#newcode18 modules/adblockplus/manifests/user.pp:18: # The user's password, as leixcal SHA1 hashsum. If ...
Jan. 13, 2016, 5:14 p.m. (2016-01-13 17:14:33 UTC) #2
mathias
Jan. 13, 2016, 5:23 p.m. (2016-01-13 17:23:45 UTC) #3
mathias
https://codereview.adblockplus.org/29333430/diff/29333431/modules/adblockplus/manifests/user.pp File modules/adblockplus/manifests/user.pp (right): https://codereview.adblockplus.org/29333430/diff/29333431/modules/adblockplus/manifests/user.pp#newcode18 modules/adblockplus/manifests/user.pp:18: # The user's password, as leixcal SHA1 hashsum. If ...
Jan. 13, 2016, 5:27 p.m. (2016-01-13 17:27:13 UTC) #4
Fred
Jan. 13, 2016, 5:42 p.m. (2016-01-13 17:42:23 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld